Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent triggering wp_print_scripts action when printing component scripts for legacy templates #1225

Closed
westonruter opened this Issue Jun 25, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@westonruter
Copy link
Member

westonruter commented Jun 25, 2018

In #1097 we eliminated use of wp_print_scripts() in favor of wp_scripts()->do_items() to prevent triggering the wp_print_scripts action, which some plugins use to output scripts to the page. This change, however, was not done similarly when printing scripts for legacy templates:

https://github.com/Automattic/amp-wp/blob/70711f0cd647f233b02ffa1bbbd58496eeeea510/includes/amp-post-template-actions.php#L67-L70

This results in a support topic like this: https://wordpress.org/support/topic/slidedeck-js-not-being-stripped/

@westonruter westonruter added this to the v0.7.2 milestone Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.