Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide auto-sanitize option when Native theme support is built-in #1358

Closed
westonruter opened this Issue Aug 27, 2018 · 2 comments

Comments

2 participants
@westonruter
Copy link
Member

westonruter commented Aug 27, 2018

When theme support is not built-in and the user selects the Native template mode, the auto-sanitize checkbox is hidden since it is forced. However, this isn't currently working when theme support is built-in via add_theme_support('amp'):

image

@westonruter

This comment has been minimized.

Copy link
Member Author

westonruter commented Aug 27, 2018

The problem lies here:

https://github.com/Automattic/amp-wp/blob/0401d5e971aa29c3fc2c9981af41ca51e7d807cf/includes/options/class-amp-options-menu.php#L261-L262

When AMP support is built-in the jQuery( 'input[type=radio][name="amp-options[theme_support]"]' ) result is empty because there are no template mode radio buttons.

@westonruter westonruter added this to the v1.0 milestone Aug 27, 2018

@westonruter westonruter added this to To do in v1.0 Aug 27, 2018

@westonruter westonruter moved this from To do to Ready for review in v1.0 Aug 29, 2018

@hellofromtonya hellofromtonya moved this from Ready for review to Ready for QA in v1.0 Aug 29, 2018

@kienstra

This comment has been minimized.

Copy link
Collaborator

kienstra commented Sep 18, 2018

Moving To 'Ready For Merging'

If it's alright, I'm moving this to 'Ready For Merging,' as I don't think it needs functional testing. Feel free to move it back.

@kienstra kienstra moved this from Ready for QA to Ready for Merging in v1.0 Sep 18, 2018

@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.