New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved “Error Isolation” view #1364

Closed
postphotos opened this Issue Aug 27, 2018 · 10 comments

Comments

5 participants
@postphotos
Contributor

postphotos commented Aug 27, 2018

As a developer using the AMP for WordPress plugin, I should have a way to isolate one error's occurrences across multiple URLs on a site and be able to quickly action to suppress or acknowledge it in a listing page.

  • AC1: Continuing to use the table listing view, incorporate the new design linked below.

    • Remove the "Removed Elements" and "Removed Attributes" and replace it with a "Removed" column that also includes occurrences where any other items that are sanitized (e.g. CSS) would be removed as well.
    • Update the "Sources" design to incorporate better organization of information.
    • Rename the "Date" column to "Last Checked."
  • AC2: Surface the error's information so that I can understand the relevance of this drilldown. Reveal the error name, its actioned status, as well as a reported blob of that error so I can understand what this page means. In that same area, I should have a clear place that links me to official documentation that a) explains the error and b) how to best fix it based on my use case (e.g. what to do when I have excessive CSS, a JS-driven script for a menu, etc.) so I, as a developer, have confidence to action quickly here.

  • AC3: In the same area where errors are detailed, give me a clear place to action - tell me what I can do (accept/reject) with this error.

Based on the "drilldown" screen from here here.
(From Ryan: it looks like this is the latest design) Final design: [ Page 1 ]

@postphotos postphotos added the release label Aug 27, 2018

@postphotos postphotos added this to the v1.0 milestone Aug 27, 2018

@hellofromtonya hellofromtonya added this to Definition in v1.0 Aug 27, 2018

@postphotos postphotos moved this from Definition to To do in v1.0 Aug 30, 2018

@postphotos postphotos moved this from To do to Definition in v1.0 Aug 30, 2018

@postphotos postphotos moved this from Definition to To do in v1.0 Sep 4, 2018

@postphotos

This comment has been minimized.

Contributor

postphotos commented Sep 4, 2018

As discussed in today's backlog grooming call, this screen's intention is to

  • Give clear details for a single error's occurrences across many URLs
  • Give them a way to action on that error (accept, reject, etc.)
  • Explain what errors happen, when and why so that developers can confidently understand how to action on a given error.

@postphotos postphotos changed the title from Improved “Error Drilldown by URL” view to Improved “Error Isolation” view Sep 5, 2018

@kienstra kienstra self-assigned this Sep 7, 2018

@kienstra kienstra moved this from To do to In progress in v1.0 Sep 7, 2018

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Sep 7, 2018

In Progress

I'm working on this now, on this branch.

Hi @jacobschweitzer,
Wow, sorry. This issue is yours. I'm actually working on #1365.

@kienstra kienstra removed their assignment Sep 8, 2018

@kienstra kienstra moved this from In progress to To do in v1.0 Sep 8, 2018

@postphotos postphotos referenced this issue Sep 10, 2018

Open

Tooltips for Compatibility Tool #1400

1 of 4 tasks complete
@postphotos

This comment has been minimized.

Contributor

postphotos commented Sep 11, 2018

Hi @kienstra and @jacobschweitzer - Mocks have been updated here.

@jacobschweitzer

This comment has been minimized.

Collaborator

jacobschweitzer commented Sep 19, 2018

This is ready for a review @westonruter

@jacobschweitzer jacobschweitzer moved this from In progress to Ready for review in v1.0 Sep 19, 2018

@jacobschweitzer

This comment has been minimized.

Collaborator

jacobschweitzer commented Sep 19, 2018

The "Learn More" button in the design was not included since there isn't a clear definition of how this will work yet. This is being worked on in #1420 .

@jacobschweitzer

This comment has been minimized.

Collaborator

jacobschweitzer commented Sep 19, 2018

Here is the pull request

@postphotos

This comment has been minimized.

Contributor

postphotos commented Sep 20, 2018

@jacobschweitzer - the links to "Learn more" would be linking to the product site's docs when they are ready. 😄

@postphotos postphotos reopened this Sep 20, 2018

@kienstra kienstra moved this from Ready for review to Ready for QA in v1.0 Sep 24, 2018

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Sep 25, 2018

Request For Testing

Hi @csossi,
Could you please test this single error page against this issue's ACs and the design?

This section is expected to be different from the design, though we're still discussing it:

single-error-page

Please also test the inline and bulk actions:
bulk-actions-single-error

@kienstra kienstra assigned csossi and unassigned westonruter Sep 25, 2018

@csossi

This comment has been minimized.

csossi commented Sep 26, 2018

verified in QA

@csossi csossi moved this from Ready for QA to Ready for Merging in v1.0 Sep 26, 2018

@csossi csossi removed their assignment Sep 26, 2018

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Sep 26, 2018

Thanks, @csossi!

@kienstra kienstra closed this Oct 23, 2018

@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment