Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sidebar to AMP Story pages #2639

Closed
westonruter opened this issue Jun 15, 2019 · 5 comments

Comments

@westonruter
Copy link
Member

@westonruter westonruter commented Jun 15, 2019

  • Register a new nav menu location for AMP Stories
  • Add amp-sidebar with the wp_nav_menu() call to the PHP template

Needs more discussion.

@swissspidy

This comment has been minimized.

Copy link
Collaborator

@swissspidy swissspidy commented Jun 17, 2019

ampproject/amphtml#16532 has some examples of this. From what I can see, it seems that some customization might be wanted there, e.g. with colors and showing the site logo.

@swissspidy

This comment has been minimized.

Copy link
Collaborator

@swissspidy swissspidy commented Jun 17, 2019

Another use case for the sidebar: a table of contents. See #2645.

@cathibosco

This comment has been minimized.

Copy link

@cathibosco cathibosco commented Aug 12, 2019

It would be useful for navigating back to a publisher's site, or to an archive stories page, or to next story, or to related stories....

@westonruter

This comment has been minimized.

Copy link
Member Author

@westonruter westonruter commented Aug 12, 2019

It would be useful for navigating back to a publisher's site, or to an archive stories page, or to next story, or to related stories....

Some of these would be better suited for the bookend (#2442)

@ThierryA ThierryA closed this Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.