Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta tag for identifying AMP pages generated by plugin #807

Closed
amedina opened this issue Nov 16, 2017 · 2 comments

Comments

Projects
5 participants
@amedina
Copy link
Member

commented Nov 16, 2017

[Edited] Refer to the latest acceptance criteria.


It would be very useful to have a distinct signature for easily identifying AMP pages generated by the plugin; something along these lines:

<meta name="generator" content="AMP Plugin v0.5.1" />

@westonruter westonruter added this to To Do in v0.6 via automation Nov 17, 2017

@westonruter westonruter added this to the v0.6 milestone Nov 17, 2017

vaporwavre added a commit to vaporwavre/amp-wp that referenced this issue Nov 23, 2017

@ThierryA ThierryA moved this from To Do to In Progress in v0.6 Nov 27, 2017

@ThierryA ThierryA assigned ThierryA and unassigned ThierryA Nov 27, 2017

@MackenzieHartung

This comment has been minimized.

Copy link
Collaborator

commented Nov 27, 2017

Acceptance Criteria

  1. The plugin will automatically generate a meta tag for easy identification of AMP Pages.
  2. The meta tag will be as follows (or the like):
<meta name="generator" content="AMP Plugin v0.5.1" />

@ThierryA ThierryA moved this from In Progress to QA in v0.6 Dec 5, 2017

@ThierryA ThierryA moved this from QA to In Progress in v0.6 Dec 5, 2017

@ThierryA ThierryA closed this in 6df01e9 Dec 5, 2017

@ThierryA ThierryA moved this from In Progress to QA in v0.6 Dec 5, 2017

@csossi

This comment has been minimized.

Copy link
Collaborator

commented Dec 8, 2017

Tag appearing as:
<meta name="generator" content="AMP Plugin v0.6.0-alpha" />

on AMP pages

@csossi csossi moved this from QA to Ready for Merging in v0.6 Dec 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.