New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow themes to register support for AMP canonical mode #848

Closed
ThierryA opened this Issue Jan 9, 2018 · 1 comment

Comments

Projects
2 participants
@ThierryA
Copy link
Collaborator

ThierryA commented Jan 9, 2018

Acceptance Criteria

AC1: Allow themes to register support for AMP canonical with add_theme_support( 'amp' ) (As @westonruter’s comment proposed).
AC2: If support is added, this would remove paired mode. The site would only serve AMP, and there wouldn’t be /amp or ?amp URLs.

Tasks

  • Check if AMP theme support exists, and if so, do not activate the current AMP templating system and the current paired mode.
  • When AMP theme support is present, prevent AMP rel link in head and other frontend actions that assume paired mode.

@ThierryA ThierryA added this to the v0.7 milestone Jan 9, 2018

@MackenzieHartung MackenzieHartung added this to To Do in v0.7 Jan 9, 2018

@MackenzieHartung MackenzieHartung moved this from To Do to Definition in v0.7 Jan 9, 2018

@MackenzieHartung MackenzieHartung moved this from Definition to To Do in v0.7 Jan 9, 2018

@kienstra

This comment has been minimized.

Copy link
Collaborator

kienstra commented Jan 10, 2018

In Development

Hi @ThierryA,
Thanks for these acceptance criteria. I'm working on this now.

@kienstra kienstra moved this from To Do to In Progress in v0.7 Jan 10, 2018

@kienstra kienstra moved this from In Progress to Ready for Review in v0.7 Jan 11, 2018

@ThierryA ThierryA moved this from Ready for Review to QA in v0.7 Jan 11, 2018

@ThierryA ThierryA moved this from QA to Ready for Merging in v0.7 Jan 18, 2018

@ThierryA ThierryA added the Sprint 2 label Mar 8, 2018

@ThierryA ThierryA moved this from Ready for Merging to Beta Release in v0.7 Mar 8, 2018

@kevincoleman kevincoleman moved this from Beta Release to Production Release in v0.7 May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment