New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support submitting comments to WordPress #862

Closed
ThierryA opened this Issue Jan 15, 2018 · 2 comments

Comments

Projects
4 participants
@ThierryA
Copy link
Collaborator

ThierryA commented Jan 15, 2018

Acceptance Criteria

AC1: The commenting experience that is native to WordPress needs to be supported in the AMP theme.
AC2: A user will need the ability to access the comment form, enter comment, and successfully submit a comment, as they do today.

Tasks

  • Add comment list template
  • Add comment form template + submission
@alcurrie

This comment has been minimized.

Copy link
Collaborator

alcurrie commented Feb 6, 2018

These are the same notes as in #862
Functionality looks good and works well, but I noticed a few items that were not as expected:

  1. Issue: Comment moderation does not display comments for previously approved comment authors.
    Expected
    In the Discussion Settings, when the Before a comment appears: Comment must be manually approved (is 'unchecked'), and Comment Author must have a previously approved comment is checked (See screen cast of settings https://cl.ly/442k1O2z1J0b)
    I expect that when I enter the same Name and email as a user whose comments have already been approved, that my comment will display right away.
    Actual
    Even if the comment author has been previously approved, comment does not display.

  2. The confirmation of the comment post, is too close to the Post comment button:
    screen shot 2018-02-05 at 7 27 41 pm

  3. From a usability perspective the comments seem quite far away from the actual article with several other articles between the bottom of the article the user is commenting on, with 3 other articles between the article and the comments on the article
    https://cl.ly/1x0g0H0K421k

@csossi

This comment has been minimized.

Copy link

csossi commented Feb 8, 2018

see Anne Louise's comments above

@ThierryA ThierryA added the Sprint 5 label Mar 8, 2018

@ThierryA ThierryA added this to Beta Release in v0.7 Mar 8, 2018

@kevincoleman kevincoleman moved this from Beta Release to Production Release in v0.7 May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment