Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions tested in Travis build matrix #1058

Merged
merged 4 commits into from Apr 4, 2018

Conversation

Projects
2 participants
@westonruter
Copy link
Member

westonruter commented Apr 4, 2018

  • Add PHP 7.2 to Travis test matrix; WordPress currently recommends PHP 7.2.
  • Include testing PHP 5.6 (the most popular PHP version), as well as 5.5.
  • Include testing WP 4.8 and trunk.
  • Skip running PHPCS on every build; only needs to be run once.
  • Clean up some PHPCS issues along the way to cause PHP to be checked in the build.

@westonruter westonruter added this to the v0.7 milestone Apr 4, 2018

@westonruter westonruter added this to Ready for Review in v0.7 Apr 4, 2018

@westonruter westonruter requested a review from kienstra Apr 4, 2018

@kienstra
Copy link
Collaborator

kienstra left a comment

Nice PR, Minor Suggestion

Hi @westonruter,
This PR looks good. Travis should run faster now that PHPCS only runs once. There are also good DocBlock and coding style improvements.

There's a minor suggestion here, but it's fine otherwise.

* @param WP_Post $post Post.
*
* @return array Modified metadata array.
*/
function jetpack_amp_post_template_metadata( $metadata, $post ) {
if ( isset( $metadata['publisher'] ) && ! isset( $metadata['publisher']['logo'] ) ) {
$metadata = wpcom_amp_add_blavatar_to_metadata( $metadata, $post );

This comment has been minimized.

Copy link
@kienstra

kienstra Apr 4, 2018

Collaborator

It'd probably be good to remove the second $post argument of wpcom_amp_add_blavatar_to_metadata() here, as the function function now only accepts one argument.

This comment has been minimized.

Copy link
@westonruter

westonruter Apr 4, 2018

Author Member

Good catch. Fixed in f683d9f.

*
* @todo Move this into Jetpack. See https://github.com/Automattic/amp-wp/issues/1021
* @package AMP
*/

This comment has been minimized.

Copy link
@kienstra

kienstra Apr 4, 2018

Collaborator

Nice additions of DocBlocks and improvements in coding style here.

@kienstra kienstra assigned westonruter and unassigned kienstra Apr 4, 2018

@westonruter westonruter merged commit 0ff5c4b into 0.7 Apr 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter moved this from Ready for Review to QA in v0.7 Apr 4, 2018

@westonruter westonruter deleted the update/travis-test-include-matrix branch Apr 5, 2018

@MackenzieHartung MackenzieHartung moved this from QA to Ready for Merging in v0.7 Apr 18, 2018

@kevincoleman kevincoleman moved this from Ready for Merging to Production Release in v0.7 May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.