New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent MediaElement.js scripts and styles from being enqueued #1061

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
3 participants
@westonruter
Copy link
Member

westonruter commented Apr 6, 2018

I noticed that when using an audio/video media widget that MediaElement.js scripts and styles are getting enqueued erroneously. Since we're using AMP components for playing media instead of MediaElement.js it doesn't make sense for these to be enqueued to begin with.

See:

@westonruter westonruter added this to the v0.7 milestone Apr 6, 2018

@westonruter westonruter requested a review from kienstra Apr 6, 2018

@westonruter westonruter added this to Ready for Review in v0.7 Apr 6, 2018

@kienstra
Copy link
Collaborator

kienstra left a comment

Approved

Hi @westonruter,
Thanks for fixing this enqueuing of MediaElement styles and scripts. This looks good.

@westonruter westonruter changed the base branch from develop to 0.7 Apr 6, 2018

@westonruter westonruter merged commit 5ba9f5b into 0.7 Apr 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/mediaelement-enqueues branch Apr 6, 2018

@kienstra kienstra moved this from Ready for Review to Ready for Merging in v0.7 Apr 6, 2018

@kevincoleman kevincoleman moved this from Ready for Merging to Production Release in v0.7 May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment