New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AMP admin menu option when AMP customizer not enabled or Theme Support enabled. #1080

Merged
merged 2 commits into from Jun 20, 2018

Conversation

Projects
None yet
3 participants
@oscarssanchez
Contributor

oscarssanchez commented Apr 17, 2018

Hi @westonruter, @kienstra,

Could you use this PR to solve: #1069 ?

I hope I understood the issue correctly. Glad to hear any feedback. Thanks!

Fixes #1069.

@kienstra

This comment has been minimized.

kienstra commented on includes/admin/functions.php in bd633dc Apr 17, 2018

It'd be good to have a comment above this like:

/** This filter is documented in wp-includes/formatting.php */

Of course, change the comment for this filter.

@oscarssanchez

This comment has been minimized.

Contributor

oscarssanchez commented Apr 17, 2018

Hi @kienstra,

I just made the change. Thanks!

@westonruter westonruter added this to the v1.0 milestone Jun 20, 2018

@westonruter westonruter merged commit 0e3e0cc into ampproject:develop Jun 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

westonruter added a commit that referenced this pull request Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment