New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spaces around commas in value property lists #1112

Merged
merged 1 commit into from May 3, 2018

Conversation

3 participants
@westonruter
Copy link
Member

westonruter commented May 3, 2018

This prevents the following from being erroneously reported as a validation error:

<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">

The spaces between values are perfectly fine.

@westonruter westonruter added this to the v1.0 milestone May 3, 2018

@westonruter westonruter requested a review from kienstra May 3, 2018

@kienstra
Copy link
Collaborator

kienstra left a comment

Approved

Hi @westonruter,
This looks good, and it fixed the issue locally.

I also saw the invalid_element error in the validator, when using your <meta> snippet above in header.php.

Removed:
><head …>  <meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1">…

With this PR applied, that error doesn't appear.

@westonruter westonruter merged commit 8f0c5ca into develop May 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@postphotos postphotos added this to Definition in v1.0 May 22, 2018

@westonruter westonruter moved this from Definition to Ready for QA in v1.0 May 22, 2018

@kienstra kienstra moved this from Ready for QA to Ready for Merging in v1.0 Jun 6, 2018

@westonruter westonruter deleted the fix/meta-viewport-value-spaces branch Jul 5, 2018

@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment