Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply the extracted dimensions to images determined to need them #1117

Merged
merged 2 commits into from May 5, 2018
Commits on May 4, 2018
  1. Supply the dimensions that are determined

    westonruter committed May 4, 2018
Commits on May 5, 2018
  1. Let supplied image sizes respect ratio of underlying image dimensions

    westonruter committed May 5, 2018
    * Update image tests to test for normal success case of image dimensions being extracted.
    * Add test case for when fallback dimensions are provided.
    * When image has one dimension but lacks another, ensure missing dimensions gets same ratio as underlying image when supplied.
    * Only add amp-wp-unknown-* classes if the dimensions are actually unknown (and fallbacks are used).
    * Restore use of content_max_width instead of FALLBACK_WIDTH if defined.
You can’t perform that action at this time.