New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Add AMP media blocks #1155

Merged
merged 21 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@miina
Copy link
Collaborator

miina commented May 17, 2018

Adds the following media blocks:

  • amp-o2-player
  • amp-ooyala-player
  • amp-playbuzz
  • amp-reach-player
  • amp-springboard-player
  • amp-jwplayer
  • amp-brid-player
  • amp-ima-video

Also todo:

  • Test everything;

Relevant notes

  • Note that the PR is not trying to embed the players inside the editor and instead is displaying the following placeholder (similar to core Facebook embed block):
    screen shot 2018-05-17 at 7 27 55 pm

  • Includes all the relevant fields for configuring the AMP component and also layout, width, and height attributes. For example:
    screen shot 2018-05-17 at 7 29 07 pm

  • There are some @todo comments in the code which could potentially be considered for the next iteration of the blocks.

@miina miina changed the title [WIP] [Gutenberg] Add AMP media blocks [Gutenberg] Add AMP media blocks May 18, 2018

@miina miina requested review from kienstra and westonruter May 18, 2018

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented May 23, 2018

Conflicts need to be resolved.

@miina

This comment has been minimized.

Copy link
Collaborator

miina commented May 23, 2018

@westonruter Conflicts resolved.

miina and others added some commits May 23, 2018

@westonruter westonruter added this to the v1.0 milestone May 23, 2018

@westonruter westonruter merged commit 91108da into develop May 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/amp_media_blocks branch May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment