New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent erroneously tree-shaking keyframe selectors like 'from', 'to', and percentages #1211

Merged
merged 1 commit into from Jun 14, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Jun 13, 2018

Tree shaking was erroneously removing keyframes selectors, turning:

@keyframes foo { 
    from { opacity:0; } 
    to { opacity:1; }  }
}

into

@keyframes foo {}

Obviously this is wrong.

@westonruter westonruter added this to the v1.0 milestone Jun 13, 2018

@westonruter westonruter requested a review from kienstra Jun 13, 2018

@westonruter westonruter force-pushed the fix/keyframes-tree-shaking branch from a6dc92f to aa7d12e Jun 13, 2018

@westonruter westonruter force-pushed the fix/keyframes-tree-shaking branch from aa7d12e to 519f8c7 Jun 14, 2018

@amedina amedina self-requested a review Jun 14, 2018

@amedina

LGTM. Ship it!

@westonruter westonruter merged commit 9461da6 into develop Jun 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/keyframes-tree-shaking branch Jun 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment