Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for allowing a site subset to be native AMP #1235

Merged
merged 34 commits into from Jul 2, 2018
Merged

Add support for allowing a site subset to be native AMP #1235

merged 34 commits into from Jul 2, 2018

Commits on Jun 27, 2018

  1. WIP

    @westonruter
    westonruter committed Jun 27, 2018
    Copy the full SHA
    143cd2a View commit details
    Browse the repository at this point in the history

  2. WIP2

    @westonruter
    westonruter committed Jun 27, 2018
    Copy the full SHA
    6149da1 View commit details
    Browse the repository at this point in the history

  3. WIP3

    @westonruter
    westonruter committed Jun 27, 2018
    Copy the full SHA
    fab22d4 View commit details
    Browse the repository at this point in the history

  4. WIP4

    @westonruter
    westonruter committed Jun 27, 2018
    Copy the full SHA
    718e643 View commit details
    Browse the repository at this point in the history

  5. WIP5

    @westonruter
    westonruter committed Jun 27, 2018
    Copy the full SHA
    1d2053c View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. WIP6

    @westonruter
    westonruter committed Jun 28, 2018
    Copy the full SHA
    2eda94b View commit details
    Browse the repository at this point in the history

  2. WIP7

    @westonruter
    westonruter committed Jun 28, 2018
    Copy the full SHA
    3377ecf View commit details
    Browse the repository at this point in the history

  3. Remove needless get_query_template

    @westonruter
    westonruter committed Jun 28, 2018
    Copy the full SHA
    e5f4b77 View commit details
    Browse the repository at this point in the history

  4. WIP8

    @westonruter
    westonruter committed Jun 28, 2018
    Copy the full SHA
    a7bf31e View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2018

  1. WIP9 [ci skip]

    @westonruter
    westonruter committed Jun 29, 2018
    Copy the full SHA
    f440592 View commit details
    Browse the repository at this point in the history

  2. WIP10 [ci skip]

    @westonruter
    westonruter committed Jun 29, 2018
    Copy the full SHA
    8f46ee7 View commit details
    Browse the repository at this point in the history

  3. WIP11 [ci skip]

    @westonruter
    westonruter committed Jun 29, 2018
    Copy the full SHA
    0131c52 View commit details
    Browse the repository at this point in the history

  4. WIP12 [ci skip]

    @westonruter
    westonruter committed Jun 29, 2018
    Copy the full SHA
    5288ccb View commit details
    Browse the repository at this point in the history

  5. WIP13 [ci skip]

    @westonruter
    westonruter committed Jun 29, 2018
    Copy the full SHA
    3f4ef4c View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2018

  1. Don't show post enable/disable if template is not available 

    Fix up some tests
Address CR feedback

[ci skip]
    @westonruter
    westonruter committed Jun 30, 2018
    Copy the full SHA
    a616e84 View commit details
    Browse the repository at this point in the history

  2. Simplify logic in AMP_Post_Meta_Box::render_status 

    [ci skip]
    @westonruter
    westonruter committed Jun 30, 2018
    Copy the full SHA
    a7371d1 View commit details
    Browse the repository at this point in the history

  3. Fix tests regarding amp status metabox 

    [ci skip]
    @westonruter
    westonruter committed Jun 30, 2018
    Copy the full SHA
    1adad3e View commit details
    Browse the repository at this point in the history

  4. Mock the gfycat requests during unit tests 

    [ci skip]
    @westonruter
    westonruter committed Jun 30, 2018
    Copy the full SHA
    fafb94e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2018

  1. Let template_availability return supported when no templates match bu… 

    …t all supported

* Fix remaining unit tests
* Mock external HTTP requests

[ci skip]
    @westonruter
    westonruter committed Jul 1, 2018
    Copy the full SHA
    95fd958 View commit details
    Browse the repository at this point in the history

  2. Add unrecognized_templates_supported for Other templates 

    [ci skip]
    @westonruter
    westonruter committed Jul 1, 2018
    Copy the full SHA
    7e56c8b View commit details
    Browse the repository at this point in the history

  3. Let theme support args define templates_supported 

    * Make sure admin screen shows proper options when optional amp theme support has been disabled.
* Add get_theme_support_args method.
    @westonruter
    westonruter committed Jul 1, 2018
    Copy the full SHA
    bfb202a View commit details
    Browse the repository at this point in the history

  4. Persist user selection even when checkbox disabled 

    * De-duplicate logic
    @westonruter
    westonruter committed Jul 1, 2018
    Copy the full SHA
    2062816 View commit details
    Browse the repository at this point in the history

  5. Add tests for read_theme_support, is_support_added_via_option, get_th… 

    …eme_support_args

Store version with options to keep track of format
    @westonruter
    westonruter committed Jul 1, 2018
    Copy the full SHA
    1c759e5 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. Improve testing of finish_init; add test stubs 

    * Clean up covers tags
* Remove unnecessary is_template_support_required
    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    221c3f0 View commit details
    Browse the repository at this point in the history

  2. Discard matching is_home when there are other matching templates

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    3d07eac View commit details
    Browse the repository at this point in the history

  3. Elimiante Other/unrecognized template option since indistinguishable … 

    …from is_home

* Devs should use filter to add support for custom templates
* When a custom template is added via amp_supportable_templates filter then is_home will be discarded if there is another match
    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    c32d76b View commit details
    Browse the repository at this point in the history

  4. Restore the availability of AMP components in non-AMP documents in na… 

    …tive sites

Revert "Remove dirty AMP support; rename Disabled to Classic"

This reverts most of commit 5bae33e.
    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    1bc4251 View commit details
    Browse the repository at this point in the history

  5. Remove unused variable and fix phpcs issue

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    11ea3d1 View commit details
    Browse the repository at this point in the history

  6. Add tests for AMP_Theme_Support::get_supportable_templates()

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    4bde27d View commit details
    Browse the repository at this point in the history

  7. Add test for AMP_Theme_Support::get_template_availability()

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    c172763 View commit details
    Browse the repository at this point in the history

  8. Add test for custom template

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    38b5546 View commit details
    Browse the repository at this point in the history

  9. Restore available_callback but mark as deprecated 

    Use _doing_it_wrong() instead of trigger_error()
    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    acf9849 View commit details
    Browse the repository at this point in the history

  10. Fix generation of AMP permalink for attachments

    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    7091b35 View commit details
    Browse the repository at this point in the history

  11. Fix initialization of paried mode and Customizer, and fix support opt… 

    …ions on admin screen
    @westonruter
    westonruter committed Jul 2, 2018
    Copy the full SHA
    b54fcc0 View commit details
    Browse the repository at this point in the history