New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure redirect is only done if there are unsanitized errors #1241

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Jul 3, 2018

In testing, I was seeing something unexpected on a paired install. When accessing ?amp I was getting redirected to ?amp_validation_errors=0. It's clear why.

Follow-up on #1207

@westonruter westonruter added this to the v1.0 milestone Jul 3, 2018

@westonruter westonruter requested a review from kienstra Jul 3, 2018

@kienstra

kienstra approved these changes Jul 3, 2018 edited

Approved

This looks good, and it makes sense that this only redirect to a non-AMP URL if there's a blocking error.

@westonruter westonruter merged commit cfa5386 into develop Jul 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/redirect branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment