New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-in to CORS mode for external font stylesheet links #1289

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Member

westonruter commented Jul 30, 2018

Opt-in to CORS mode for external font stylesheet links
This ensures that a service worker caching an external stylesheet will not inflate the storage quota.

@westonruter westonruter added the pwa label Jul 30, 2018

@westonruter westonruter added this to the v1.0 milestone Jul 30, 2018

@westonruter westonruter requested review from amedina and kienstra Jul 30, 2018

@kienstra

kienstra approved these changes Jul 31, 2018 edited

Approved

Hi @westonruter,
Good idea to add a crossorigin to <link> elements that don't already have one. This PR looks good, and it looks to work as expected:

link-crossorigin

@westonruter westonruter merged commit 21ebbc6 into develop Jul 31, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/external-stylesheet-link-cors-opt-in branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment