New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix including external stylesheets on Windows #1311

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
3 participants
@westonruter
Member

westonruter commented Aug 2, 2018

  • Remove needless validate_file() call.
  • Fix usage of strpos() and include check for Windows and Linux relative paths.
  • Add file_path_not_allowed error code in addition to existing file_path_not_found error code.

Build of plugin to test: amp.zip (v1.0-beta1-8a0a172a-20180802T223339Z)

To test this build, deactivate and uninstall your existing AMP plugin. Then go to the Add New plugin admin screen. Click the “Upload Plugin” button at the top and select amp.zip:

image

Then activate the plugin and test.

Fixes #1310.

@christophherr

This comment has been minimized.

christophherr commented Aug 2, 2018

@westonruter
Confirming this version fixes the file_path_not_found errors and external stylesheets are loading on Windows 10 for me.
Thank you.

@hellofromtonya

Nice fix, @westonruter. Thank you @christophherr for testing and helping with this Windows issue.

@hellofromtonya hellofromtonya merged commit 8d5d587 into develop Aug 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/windows-validated-url-file-path branch Aug 3, 2018

@Flapjac Flapjac referenced this pull request Nov 21, 2018

Closed

CSS doesn't work #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment