Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec generation to file revision 675 (amphtml tag 1531357871900) #1312

merged 4 commits into from Aug 3, 2018


None yet
2 participants
Copy link

westonruter commented Aug 3, 2018

Since the generated file hasn't been updated in a few months (since May 23rd via #1172), the spec from July 11 (v1531357871900) is being used before going all the way to the most recent version. The main reason is that there are changes to the validator spec format that need some more investigation and I wanted to limit the scope of the changes.

  • Check out latest tag when updating from AMP spec instead of master.
  • Add new components: amp-3d-gltf, amp-date-countdown, amp-google-document-embed, amp-orientation-observer, amp-pan-zoom, and amp-yotpo.
  • Update allowed attributes on amp-accordion, amp-brightcove, amp-position-observer, amp-story-bookend, amp-twitter, and amp-vimeo.
  • While this update allows inline style attribute when not !important, the style sanitizer will continue to extract inline styles to combine into style[amp-custom]. In the future we can explore leaving these inline, but in the case of !important we'll have to continue extracting to create the higher-specificity selector rules. And if we selectively move such non-important inline styles to style[amp-custom] there could be unintended side effects with the cascade. So we'll revisit this in the future.

westonruter added some commits Aug 3, 2018

Fix unit tests broken now that inline styles are allowed
Simply add !important to the inline styles to ensure they get flagged as invalid
Copy link

hellofromtonya left a comment

Good work @westonruter

@hellofromtonya hellofromtonya merged commit f6b28d6 into develop Aug 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@westonruter westonruter deleted the update/amp-spec-1531357871900 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.