New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect default AMP enabled status when creating a new post in Gutenberg #1339

Merged
merged 1 commit into from Aug 14, 2018

Conversation

3 participants
@hellofromtonya
Copy link
Collaborator

hellofromtonya commented Aug 14, 2018

When first loading a new post, AMP status has not been set yet been saved as meta. Though the Enable AMP toggle shows it as enabled, it's using window.wpAmpEditor.defaultStatus to set the default status.

This PR uses that same strategy for block validation.

Use AMP status default when adding a new post.
When first loading a new post, AMP status has not been set yet by the Enable AMP toggle.  Instead, we'll use default status.

@hellofromtonya hellofromtonya added this to the v1.0 milestone Aug 14, 2018

@hellofromtonya hellofromtonya requested a review from westonruter Aug 14, 2018

@westonruter westonruter changed the title Enable AMP on New Post Respect default AMP enabled status when creating a new post in Gutenberg Aug 14, 2018

@westonruter westonruter merged commit 75bc236 into develop Aug 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/enable-amp-on-new-post branch Aug 14, 2018

@postphotos postphotos added this to Definition in v1.0 Aug 15, 2018

@westonruter westonruter moved this from Definition to Ready for review in v1.0 Aug 15, 2018

@westonruter westonruter moved this from Ready for review to Ready for QA in v1.0 Aug 15, 2018

@kienstra

This comment has been minimized.

Copy link
Collaborator

kienstra commented Sep 5, 2018

Moving To 'Ready for Merging'

If it's alright, I'm moving this to 'Ready for Merging,' as I'm not sure it needs functional testing.

@kienstra kienstra moved this from Ready for QA to Ready for Merging in v1.0 Sep 5, 2018

@kienstra kienstra moved this from Ready for Merging to In Production in v1.0 Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment