New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip check_supported_post_type_update_errors if all templates supported #1344

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

westonruter commented Aug 16, 2018

This is a follow-up to #1338 for #1302.

When Jetpack's custom content types enabled, I found I was still getting the error messages unexpectedly:

screen shot 2018-08-16 at 6 35 00 am

The fix seems to be that we need to skip the check if the all_templates_supported option is enabled (which is only available in the native/paired theme modes).

@westonruter westonruter added this to the v1.0 milestone Aug 16, 2018

@hellofromtonya hellofromtonya merged commit df6b433 into develop Aug 16, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/erroneous-post-type-notices-2 branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment