Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure expected notice is hidden when theme support enabled by theme #1374

Merged
merged 1 commit into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

westonruter commented Aug 29, 2018

Fixes #1358.

Before

When native support added by theme

add_theme_support('amp');

image

The notice appears but the checkbox should be hidden.

When paired support added by theme

add_theme_support( 'amp', array(
	'paired' => true,
) );

image

The checkbox appears but the notice should be hidden.

After

Native mode

image

Paired mode

image

@westonruter westonruter added this to the v1.0 milestone Aug 29, 2018

@westonruter westonruter requested a review from hellofromtonya Aug 29, 2018

@hellofromtonya hellofromtonya merged commit 853f7fb into develop Aug 29, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/built-in-support-notice branch Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.