Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reference points and update spec to file revision 720 (v1534879991178) #1386

Merged
merged 11 commits into from Sep 2, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented Aug 30, 2018

  • Add support for handling reference points in validator spec, including support for attributes used by amp-next-page, amp-story, amp-lightbox-gallery, and amp-live-list. This removes hard-coded list of whitelisted attribute pattern which were erroneously being allowed on every element, not just the descendants of elements with reference points.
  • Add special case for handling reference points for amp-selector since its attributes can be added to any descendant not just direct children.
  • Add components for amp-image-slider and amp-viqeo-player.
  • Add when-ended=continue to amp-date-countdown.
  • Add [open] to amp-lightbox.
  • Add disable-double-tap to amp-pan-zoom.
Update spec to file revision 720 (v1534879991178)
* Add components for amp-image-slider, amp-viqeo-player,
* Add when-ended=continue to amp-date-countdown.
* Add [open] to amp-lightbox.
* Add disable-double-tap to amp-pan-zoom.

@westonruter westonruter added this to the v1.0 milestone Aug 30, 2018

@westonruter westonruter self-assigned this Aug 30, 2018

westonruter added some commits Aug 30, 2018

@westonruter westonruter changed the title [WIP] Update spec to file revision 720 (v1534879991178) Update spec to file revision 720 (v1534879991178) Aug 31, 2018

@westonruter westonruter changed the title Update spec to file revision 720 (v1534879991178) Add support for reference points and update spec to file revision 720 (v1534879991178) Aug 31, 2018

@westonruter westonruter requested a review from amedina Aug 31, 2018

}
}
}
return $rule_spec;

This comment has been minimized.

Copy link
@westonruter

westonruter Aug 31, 2018

Author Member

Most of this code is refactored into a separate method from below. See 002bda3 for the actual changes introduced.

}
return $rule_spec;
}
/**
* Process a node by sanitizing and/or validating it per.

This comment has been minimized.

Copy link
@amedina

amedina Sep 1, 2018

Member

Not related to this change, but this comment may need improvement: validating it per?

@amedina

amedina approved these changes Sep 1, 2018

Copy link
Member

left a comment

LGTM. Ship it.

@westonruter westonruter merged commit c2a297c into develop Sep 2, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the update/spec-1534879991178 branch Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.