Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated isCleanNewPost. #1387

Merged
merged 1 commit into from Aug 31, 2018
Merged

Conversation

@miina
Copy link
Contributor

@miina miina commented Aug 31, 2018

Looks like isCleanNewPost is going to be deprecated in 3.8, this PR replaces using the method.

@miina
Copy link
Contributor Author

@miina miina commented Aug 31, 2018

@hellofromtonya @kienstra @westonruter
Created this PR to replace the deprecated isCleanNewPost() method. Could you confirm that this is working as expected since you've worked on the block validation (AFAIK)?

@westonruter westonruter added this to the v1.0 milestone Aug 31, 2018
@westonruter westonruter removed their request for review Aug 31, 2018
@westonruter
Copy link
Member

@westonruter westonruter commented Aug 31, 2018

I will defer to @hellofromtonya as she introduced isCleanNewPost in f495ca4 for #1293.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

@miina I just ran it through a series of tests e.g. duplicating invalid blocks, new post, saving, publishing, turning on and off enable, etc. It works as expected.

Great job!

@hellofromtonya hellofromtonya merged commit c3d5c34 into develop Aug 31, 2018
2 checks passed
@westonruter westonruter deleted the fix/deprecated_isCleanNewPost branch Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants