Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Default to automatic sanitization and tree shaking #1402
It seems to me that we should default to the plugin getting some positive results upon switching to the paired mode rather than automatically redirecting to the non-AMP version with errors. The user will find out about the errors as they go when they save posts. At the very least, this should reduce the pain for new users trying out the paired mode, which should provide a much better user experience compared with the classic paired mode. Since the classic paired mode automatically removes invalid markup, having the new paired mode also default to this mode seems reasonable, especially since there will be warnings that this is occurring. They can then turn off auto-sanitization via the checkbox if it's not the behavior they want. But it seems like it will be the most frequent default that users will want.
Additionally, with improvements to the #1288, the validation status can be determined ahead of time before even enabling the native/paired modes.
Related to #1384 which is go go a step further and default to the new paired mode for new activations.
The provide a much better user experience is key here. You're right that the vast majority of users will need tree shaking by default.