Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum PHP version from 5.3.2 to 5.3.6 #1407

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

westonruter commented Sep 6, 2018

The $node attribute for DOMDocument::saveHTML() was added in 5.3.6 (for some reason). So this is the required minimum version.

Fixes #1406.

Also updates PHP-CSS-Parser from upstream to include:

westonruter added some commits Sep 6, 2018

@westonruter westonruter added this to the v1.0 milestone Sep 6, 2018

@westonruter westonruter requested a review from swissspidy Sep 6, 2018

@westonruter westonruter merged commit a2cfdb9 into develop Sep 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the update/php-min-version branch Sep 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.