The text was updated successfully, but these errors were encountered:
This is really more like an edit-tags.php page, like the 'Errors by Type' page. In that it has a WP_Terms_List_Table of validation error terms. There are several filters needed for this, including for parse_term_query.
Create add_single_post_columns(), and a corresponding unit test.
…ogic Because this now uses WP_Terms_List_Table, that meta box is probably not needed.
Question About Overall Approach
When you have a chance, could you please look at this and let me know what you think of the overall approach? Especially in #1418 (comment)
As you can see, this is WIP. But your feedback would really help to make sure this is on the right path.
…e list table Using the script that Weston began, add a method for outputting this text. It still needs to have the text translated, and to use dynamic numbers.
This moves some of the logic from enqueue_edit_post_screen_scripts() into add_edit_post_inline_script(). Because the dynamic value for the script depends on the WP_Terms_List_Table, it's now called inside render_single_url_list_table().
This isn't common, but it's possible to filter for 'JS Errors', for example, and have no errors display. In that case, there's no need for the message.
As Weston suggested. It would be ideal to do this in render_single_url_list_table(), but set_current_screen() looks to run before that, and that needs access to the $_REQUEST['taxonomy'].
render_single_url_list_table() now does not require the $_GET['taxonomy'] be set.
…s to PHP_INT_MAX As Weston mentioned, the 'Search Errors' box needs to be implemented in JS. So this removes the PHP logic. Also, it changes the max number of errors that can display on a single page from 4 to PHP_INT_MAX.
As Weston mentioned, this should be done in JS, so remove this method and its PHPUnit test.
…lumns In the 'Error' column, use ucfirst() to capitalize the error, and use str_replace() to convert underscores to spaces. In the 'Details' column, output the 'parent_name', if it exists.
…Types' As Alberto mentioned, this reflects the actual state.
…box is checked These only apply if a box is checked. On unchecking the last checked box, hide these again. @todo: fix styling issue with the error type filter <select>.
render_taxonomy_filters() isn't needed anymore So remove it, and its add_action() call. Also, move inline styling to the stylesheet.
Now that I've added non-details styling, this removes 'details' from the slug.
Like 'Showing 22 of 22 validation errors' This will show that the errors are now all displaying.
… in JS Before, the header of 'Invalid URL' displayed first, and then a JS file changed it. Now, this will be empty until the JS file applies it.
* Remove unnecessary nested posts-filter form. * Use let/const instead of var.
This 'Showing x of y' errors notice won't apply if all are showing. So on selecting 'All Error Types', or clicking 'Show all', this notice will be hidden.
…r it conditionallyCreateShowAllButton() runs right before a block that might remove its 'hidden' class. So instead of using the stored showAllButton, run a new query for it.
* Remove incorrect attribute escaping of translation exported to JS. * Restore amp-validation-error-detail-toggle to webpack config.
…age. They will only show in the error taxonomy index page, but no on this single URL page.