Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize invalid URL stored for amp_invalid_url post type #1436

Merged
merged 1 commit into from Sep 17, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

westonruter commented Sep 17, 2018

  • Prevent query vars (e.g. utm) and HTTP/HTTPS from causing different copies of invalid URL post.
  • De-duplicate logic for obtaining amp_invalid_url post for a given URL.
Normalize invalid URL stored for amp_invalid_url post type
* Prevent query vars (e.g. utm) and HTTP/HTTPS from causing different copies of invalid URL post.
* De-duplicate logic for obtaining amp_invalid_url post for a given URL.

@westonruter westonruter added this to the v1.0 milestone Sep 17, 2018

@westonruter westonruter requested a review from amedina Sep 17, 2018

@amedina
Copy link
Member

amedina left a comment

LGTM. Ship it.

@westonruter westonruter merged commit 7bd13ab into develop Sep 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/url-normalization branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.