New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issue on Error Index page, where status icon is cut off #1452

Merged
merged 2 commits into from Sep 22, 2018

Conversation

Projects
None yet
2 participants
@kienstra
Collaborator

kienstra commented Sep 22, 2018

Request For Code Review

Hi @westonruter,
Could you please review this?

As @postphotos mentioned, on the AMP Validation Error Index page, the right part of this icon is cut off, like when the status is 'New Accepted'.

So this make the column wider, to prevent this.

This new styling only applies on this AMP Validation Error Index page. It's overridden by another rule on the single error URL page.

Before:
icon-cut-off

After (with this PR):
after-not-cut-off

Fix an on 'Error Index' page, where status icon was cut off
As Leo mentioned,
the right part of this icon is cut off
when the status is 'New Accepted'.
So make the column wider, to prevent this.

@kienstra kienstra requested a review from westonruter Sep 22, 2018

@westonruter westonruter added this to the v1.0 milestone Sep 22, 2018

@westonruter

This comment has been minimized.

Member

westonruter commented Sep 22, 2018

It was still getting cut off on narrow screens, so the min-width is forcing it to not get cropped for me.

@westonruter westonruter merged commit 372f4ac into develop Sep 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the update/styling-error-index branch Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment