Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slug constants for theme support and post type support #1456

Merged
merged 2 commits into from Sep 23, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented Sep 23, 2018

Instead of using a string literal 'amp' everywhere to add/remove/get the theme support, it seems preferable to have this in a constant like AMP_Theme_Support::SLUG instead.

Likewise, when adding post type support it seems preferable that there be a constant like AMP_Post_Type_Support::SLUG as opposed to re-using amp_get_slug() whose value is variable.

westonruter added some commits Sep 23, 2018

@westonruter westonruter force-pushed the add/support-slug-constants branch from 9a874b1 to 69ac857 Sep 23, 2018

@westonruter westonruter changed the title [WIP] Add support slug constants Add slug constants for theme support and post type support Sep 23, 2018

@westonruter westonruter requested a review from hellofromtonya Sep 23, 2018

@hellofromtonya
Copy link
Contributor

left a comment

Much better solution. Thank you @westonruter

@westonruter westonruter added this to the v1.0 milestone Sep 23, 2018

@westonruter westonruter merged commit 1b3bf23 into develop Sep 23, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/support-slug-constants branch Sep 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.