Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title display of Invalid URL page #1463

Merged
merged 1 commit into from Sep 25, 2018

Conversation

@amedina
Copy link
Member

@amedina amedina commented Sep 24, 2018

Title of the Invalid URL admin screen with characters such as quotes did not displayed correctly.

@amedina amedina requested a review from westonruter Sep 24, 2018
@westonruter
Copy link
Member

@westonruter westonruter commented Sep 25, 2018

This is required because the HTML entities are being encoded into JSON and the JS is updating the heading.

@westonruter westonruter added this to the v1.0 milestone Sep 25, 2018
@westonruter westonruter merged commit 6ac962a into develop Sep 25, 2018
2 checks passed
@westonruter westonruter deleted the amedina/escape-invalid-url-page-title branch Sep 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants