Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration with WordPress 5.0 #1520

Merged
merged 8 commits into from Oct 23, 2018
Merged

Fix integration with WordPress 5.0 #1520

merged 8 commits into from Oct 23, 2018

Conversation

@miina
Copy link
Contributor

@miina miina commented Oct 22, 2018

This PR replaces relying on gutenberg_init method with relying on register_block_type method.

It's likely that gutenberg_init will be removed once the plugin gets merged into core so perhaps it makes sense to not depend on it?

@miina
Copy link
Contributor Author

@miina miina commented Oct 22, 2018

Created this PR to be prepared for Gutenberg being merged, would this make sense to merge? Thoughts? @kienstra @westonruter

@westonruter
Copy link
Member

@westonruter westonruter commented Oct 23, 2018

This is good. However, it should be rebased onto the 1.0 branch since it needs to be part of 1.0.

@westonruter westonruter self-requested a review Oct 23, 2018
@westonruter westonruter changed the base branch from develop to 1.0 Oct 23, 2018
@westonruter westonruter added this to the v1.0 milestone Oct 23, 2018
@westonruter westonruter force-pushed the fix/replace_gutenberg_init branch from acbb6d6 to a31b6d8 Oct 23, 2018
@westonruter westonruter force-pushed the fix/replace_gutenberg_init branch from c48d9fe to 9f88468 Oct 23, 2018
@westonruter westonruter changed the title Replace relying on gutenberg_init method. Fix unit tests in WordPress 5.0 Oct 23, 2018
@westonruter
Copy link
Member

@westonruter westonruter commented Oct 23, 2018

See corresponding dev-lib PR: xwp/wp-dev-lib#284

@westonruter westonruter changed the title Fix unit tests in WordPress 5.0 Fix integration with WordPress 5.0 Oct 23, 2018
@westonruter westonruter merged commit 60bf71f into 1.0 Oct 23, 2018
2 checks passed
@westonruter westonruter deleted the fix/replace_gutenberg_init branch Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants