New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMP spec to 757 (v1811091519050) #1588

Merged
merged 7 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@kienstra
Collaborator

kienstra commented Nov 4, 2018

  • Bumps $spec_file_revision from 734 to 757
  • Adds support for <amp-script> and <amp-powr-player>, <amp-skimlinks>, and more attributes for existing elements.
  • Add support for amp-inputmask.
  • Add support for SVG focusable attribute: ampproject/amphtml#19128
  • Update meta viewport handling support newly-relaxed value of just width=device-width: ampproject/amphtml#19129
  • Add @page to whitelist of CSS at-rules: ampproject/amphtml#17481

kienstra added some commits Nov 3, 2018

Run amphtml-update.sh to update to AMP spec
Bumps $spec_file_revision from 734 to 751
Adds support for <amp-script> and <picture>,
and more attributes for existing elements.
Correct failed unit tests by allowing the 'amp' or '⚡' attribute in <…
…html>

In the ammphtml repo's validator-main.protoascii,
the attrs object for html was removed.
@see ampproject/amphtml@ee9ef44#diff-695a0119f06368dee3ab53e1395ef725L77
It looks like the amphtml repo's validator has
a different way of validating the <html> tag now:
ampproject/amphtml@ee9ef44#diff-52a1cb778626c52da13d91b4849462d6R4746
So this adds an exclusion for <html amp> or <html ⚡>
in is_amp_allowed_attribute().
Before, this had returned false for those attributes,
and this resulted in the' am'pan ⚡' being removed.

@westonruter westonruter added this to the v1.0 milestone Nov 4, 2018

@westonruter westonruter referenced this pull request Nov 4, 2018

Merged

Add initial AMP support for Twenty Nineteen #1587

6 of 6 tasks complete

kienstra added some commits Nov 5, 2018

Test that the newly allowed element <amp-script> is accepted
When running the AMP_Tag_And_Attribute_Sanitizer,
it should accept the <amp-script>
Remove clause of comment ", as otherwise it will be stripped entirely"
This isn't accurate anymore,
as the generated Tag_And_Attribute_Sanitizer
doesn't have require <html> to have amp.
This is probably from changes in the amphtml repo's validator:
ampproject/amphtml@ee9ef44#diff-52a1cb778626c52da13d91b4849462d6R4746
@see commit b420a90 in this repo.

@kienstra kienstra changed the title from [WIP] Update AMP spec to 751 via amphtml-update.sh to Update AMP spec to 751 via amphtml-update.sh Nov 5, 2018

@westonruter

This comment has been minimized.

Member

westonruter commented Nov 5, 2018

I suppose it depends on the release date for the next version. If it goes live tomorrow then I'd say wait. Otherwise we'll go ahead with this now and update again.

@kienstra

This comment has been minimized.

Collaborator

kienstra commented Nov 5, 2018

Thanks, @westonruter. Still planning on releasing 1.0-RC2 tomorrow if that's alright, so we could wait on this PR if that sounds good.

@westonruter

This comment has been minimized.

Member

westonruter commented Nov 14, 2018

AMP has been updated in production to support @page and also to relax the viewport requirements, so we can update the core theme sanitizer to remove those allowed errors: https://github.com/ampproject/amphtml/releases/tag/1811091519050

westonruter added some commits Nov 15, 2018

@westonruter westonruter changed the title from Update AMP spec to 751 via amphtml-update.sh to Update AMP spec to 757 (v1811091519050) Nov 15, 2018

@westonruter westonruter merged commit 3ab2884 into 1.0 Nov 15, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment