Update AMP spec to 757 (v1811091519050) #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps $spec_file_revision from 734 to 751 Adds support for <amp-script> and <picture>, and more attributes for existing elements.
…html> In the ammphtml repo's validator-main.protoascii, the attrs object for html was removed. @see ampproject/amphtml@ee9ef44#diff-695a0119f06368dee3ab53e1395ef725L77 It looks like the amphtml repo's validator has a different way of validating the <html> tag now: ampproject/amphtml@ee9ef44#diff-52a1cb778626c52da13d91b4849462d6R4746 So this adds an exclusion for <html amp> or <html ⚡> in is_amp_allowed_attribute(). Before, this had returned false for those attributes, and this resulted in the' am'pan ⚡' being removed.
westonruter
reviewed
Nov 4, 2018
6 tasks
When running the AMP_Tag_And_Attribute_Sanitizer, it should accept the <amp-script>
This isn't accurate anymore, as the generated Tag_And_Attribute_Sanitizer doesn't have require <html> to have amp. This is probably from changes in the amphtml repo's validator: ampproject/amphtml@ee9ef44#diff-52a1cb778626c52da13d91b4849462d6R4746 @see commit b420a90 in this repo.
kienstra
changed the title
|
I suppose it depends on the release date for the next version. If it goes live tomorrow then I'd say wait. Otherwise we'll go ahead with this now and update again. |
|
Thanks, @westonruter. Still planning on releasing |
|
AMP has been updated in production to support |
westonruter
changed the title
westonruter
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$spec_file_revisionfrom734to757<amp-script>and<amp-powr-player>,<amp-skimlinks>, and more attributes for existing elements.amp-inputmask.focusableattribute: ✨ Allow SVG 'focusable' attribute from SVG Tiny 1.2 amphtml#19128width=device-width: ✨ Remove minimum-scale from required meta viewport properties amphtml#19129@pageto whitelist of CSS at-rules: 🖍 Allow @page CSS at-rule amphtml#17481