New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when AMP plugin is installed in incorrect directory #1593

Merged
merged 1 commit into from Nov 7, 2018

Conversation

2 participants
@westonruter
Member

westonruter commented Nov 7, 2018

This adds a warning admin notice when the plugin is installed in a directory other than amp (e.g. when accidentally cloning as amp-wp from GitHub).

screen shot 2018-11-07 at 9 51 58 am

@westonruter westonruter added this to the v1.0 milestone Nov 7, 2018

@westonruter westonruter requested a review from kienstra Nov 7, 2018

@westonruter westonruter force-pushed the add/incorrect-plugin-directory-name-warning branch from e6ffc12 to 50184a9 Nov 7, 2018

@westonruter westonruter added this to Ready for review in v1.0 Nov 7, 2018

@kienstra

kienstra approved these changes Nov 7, 2018 edited

Approved
Good Idea

Hi @westonruter,
This looks good.

And great idea to print this notice. The update notice references a different plugin entirely if the plugin is in an amp-wp directory:

notice-appears

@westonruter westonruter merged commit 469e992 into develop Nov 7, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/incorrect-plugin-directory-name-warning branch Nov 7, 2018

@westonruter

This comment has been minimized.

Member

westonruter commented Nov 7, 2018

Oops. Merged into wrong branch. I cherry-picked this into the 1.0 branch: 0dec4e5

@kienstra kienstra moved this from Ready for review to Ready for Merging in v1.0 Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment