Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework displaying block validation messages. #1682

Merged
merged 1 commit into from Nov 30, 2018

Conversation

@miina
Copy link
Contributor

@miina miina commented Nov 30, 2018

Fixes #1679.

@kienstra
Copy link
Contributor

@kienstra kienstra commented Nov 30, 2018

Before, In Paired Mode (Typing Is Slow)

typing-slow-gutenberg

Before, In Classic Mode

typing-fast-gutenberg

After, In Paired Mode (Typing Is Fast Again)

tpying-fast-amp-plugin-pr

Steps to reproduce:

  1. Activate any theme
  2. Select Paired mode
  3. Checkout and build the master branch of Gutenberg (though I'm not sure the version or branch matters)
  4. Create a very long post. I used the Gutenberg demo post, and copied the content 4 times so it was 5 times longer. Even then, there wasn't a huge difference, but it was noticeable.
  5. Expected: typing in the block editor shouldn't be delayed
  6. Actual: there's a delay between typing and seeing the text appear (see the first .gif above)

@kienstra
Copy link
Contributor

@kienstra kienstra commented Nov 30, 2018

Block-level Notices Still Appear

block-level-notices-appear

@kienstra
Copy link
Contributor

@kienstra kienstra commented Nov 30, 2018

Approved

Hi @miina,
Thanks a lot for fixing this issue. This PR works locally, as shown in the .gif above.

@kienstra kienstra self-requested a review Nov 30, 2018
@kienstra
Copy link
Contributor

@kienstra kienstra commented Nov 30, 2018

Request For Review

Hi @westonruter,
Could you please review this?

Also, here's a test page on a staging site where the issue exists.

Thanks, Weston 😄

@kienstra kienstra requested a review from westonruter Nov 30, 2018
@westonruter
Copy link
Member

@westonruter westonruter commented Nov 30, 2018

Massive improvement to performance. Good work @miina!

@westonruter westonruter added this to the v1.0 milestone Nov 30, 2018
@westonruter westonruter merged commit 05f2a4f into 1.0 Nov 30, 2018
2 checks passed
@swissspidy swissspidy deleted the 1679-improve_block_validation branch Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants