Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second argument of the_title filter is an Int not WP_Post. #1723

Merged
merged 2 commits into from Dec 11, 2018

Conversation

Projects
None yet
2 participants
@lesterchan
Copy link
Contributor

lesterchan commented Dec 10, 2018

The the_title applies this filter filter_the_title_in_post_list_table with two arguments. The second argument is wrong. It is an Int, not a WP_Post object. See https://codex.wordpress.org/Plugin_API/Filter_Reference/the_title

@westonruter westonruter added this to the v1.0.1 milestone Dec 11, 2018

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented Dec 11, 2018

See also #1725.

@westonruter westonruter changed the base branch from develop to 1.0 Dec 11, 2018

@westonruter westonruter force-pushed the lesterchan:develop branch from 0e90040 to c34d9ee Dec 11, 2018

@westonruter westonruter merged commit 75cdb06 into ampproject:1.0 Dec 11, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@westonruter westonruter referenced this pull request Dec 11, 2018

Merged

Bump 1.0.1 #1726

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.