Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for required iconv extension #1727

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented Dec 11, 2018

@westonruter westonruter added this to the v1.0.1 milestone Dec 11, 2018

@westonruter westonruter requested a review from kienstra Dec 11, 2018

@kienstra

This comment has been minimized.

Copy link
Collaborator

commented Dec 12, 2018

Approved

Hi @westonruter,
Sorry for the delay. This notice looks good when I change the conditional (my environment has the iconv extension):

amp-iconv-extension-notice

@westonruter westonruter merged commit 1bf0d5e into 1.0 Dec 12, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/iconv-detection branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.