Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Rebrand Classic as Reader mode and Paired as Transitional mode; add Exit Reader Mode link #2034
I decided on going with an additional link to the canonical version because using the current comments link for that would be misleading. It points to the comments section of the post, where what we want is just a link to exit Reader mode and view the canonical version. Furthermore, if we just replaced that "Leave a Comment" link with an "Exit Reader Mode" link, it would be an unexpected location for such a link, as you typically add comments below a post.
amedina left a comment
We should add a configuration option on the Reader mode selection panel, where the user opts in to having the "Exit Reader" mode link added to their templates. This would be important in cases where the addition of the link would interfere with customizations made to classic templates.
referenced this pull request
Apr 1, 2019
I think we should have a separate discussion around this and keep this PR focused on Reader and Paired modes. To me, Strict Mode is different from Native Mode:
I think Strict Mode should either be a fourth mode, or a checkbox that is available when Native Mode is active.
The exit link is now opt-in as you suggested. You can control it in the Customizer together with the other header bar customizations.