Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replace_node_with_children #449

Closed

Conversation

@Maxime2
Copy link
Contributor

Maxime2 commented Aug 23, 2016

We need to sanitize children of removed node as if there are more than one those starting from second would be missed in sanitisation in parent's foreach loop.

@mjangda
Copy link
Contributor

mjangda commented Aug 23, 2016

Thanks for the PR. Can you share some example HTML that this fixes?

@Maxime2
Copy link
Contributor Author

Maxime2 commented Aug 24, 2016

Something like that:
<a><span style="color: red;">Red</span>&amp;<span style="color: blue;">Orange</span></a>

This was referenced Aug 29, 2016
@mjangda
Copy link
Contributor

mjangda commented Sep 2, 2016

Continued in #462

@mjangda mjangda closed this Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.