Eliminate static emoji handling since most browsers now support natively#6717
Merged
westonruter merged 1 commit intodevelopfrom Nov 15, 2021
Merged
Eliminate static emoji handling since most browsers now support natively#6717westonruter merged 1 commit intodevelopfrom
westonruter merged 1 commit intodevelopfrom
Conversation
Contributor
|
Plugin builds for 7244902 are ready 🛎️!
|
westonruter
force-pushed
the
remove/emoji
branch
from
f4bd237 to
7244902
Compare
dhaval-parekh
approved these changes
Nov 15, 2021
Collaborator
|
Changes in PR looks good to me 👍 I have tested the changes in different browsers and the results are consistent across the browsers.
|
maitreyie-chavan
requested review from
bartoszgadomski
and removed request for
milindmore22
Contributor
|
QA passed:
Also, connections to |
westonruter
changed the title
westonruter
added
the
Changelogged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've been doing some looking into emoji handling in WordPress, as I've realized that I'm not seeing Twemoji images for emoji anymore. From caniemoji.com it seems all modern platforms/browsers now natively support native emoji, so the emoji detection script and
dns-prefetchfors.w.orgis largely just slowing down page performance in WordPress.For more in core:
We can improve performance of pages prepared by the AMP plugin by skipping the
wp_staticize_emoji()calls (which were neither comprehensive to the whole page nor largely necessary given native browser support), eliminating any connections to WordPress's Twemoji CDN ats.w.org.Another benefit to eliminating the use of
wp_staticize_emoji()is that it outputs not SVG but PNG images (by default), meaning they have appeared quite poor at larger font sizes.Checklist