Fix minor issues with async site scan on plugin activation#6758
Merged
westonruter merged 2 commits intodevelopfrom Dec 3, 2021
Merged
Fix minor issues with async site scan on plugin activation#6758westonruter merged 2 commits intodevelopfrom
westonruter merged 2 commits intodevelopfrom
Conversation
2 tasks
Contributor
|
Plugin builds for ed39f61 are ready 🛎️!
|
westonruter
reviewed
Dec 3, 2021
| await page.waitForSelector( `tr[data-slug="${ slug }"] .deactivate a` ); | ||
| } | ||
|
|
||
| describe( 'for a user', () => { |
Collaborator
|
QA Passed |
westonruter
added
the
Changelogged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes some minor issues discovered after #6685 has been merged:
describecalls. There's no change in the test code whatsoever f6c53f7setTimeouthas not been cleared properly before ed39f61Checklist