Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pound symbol from header id #853

Merged
merged 1 commit into from Jan 10, 2018

Conversation

Projects
None yet
2 participants
@eshannon3
Copy link
Contributor

commented Jan 10, 2018

Removed the # symbol from

id. It was causing 404 errors and
prevented the "Back to top" link in the footer from working.

Remove pound symbol from header id
Removed the # symbol from <header> id. It was causing 404 errors and
prevented the "Back to top" link in the footer from working.
@westonruter
Copy link
Member

left a comment

Good catch.

@westonruter

This comment has been minimized.

Copy link
Member

commented Jan 10, 2018

@ThierryA we might as well merge this into 0.6 as well.

@westonruter westonruter added this to the v0.6 milestone Jan 10, 2018

@westonruter westonruter merged commit 632c853 into ampproject:develop Jan 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

westonruter added a commit that referenced this pull request Jan 10, 2018

Merge pull request #853 from eshannon3/eshannon3/fix-header-id to 0.6…
… branch

Remove erroneous hash from id on amp-wp-header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.