Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect amp_css_bad_file_extension prior to looking at filesystem #890

Merged
merged 1 commit into from Jan 26, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented Jan 23, 2018

Amends #887

@westonruter westonruter added this to the v0.7 milestone Jan 23, 2018

@westonruter westonruter requested a review from ThierryA Jan 23, 2018

@ThierryA
Copy link
Collaborator

left a comment

This PR is good to go, however it seems like there is an issue with the error being displayed twice. Actually an error with the theme index.php being called twice. Weston do you also experiment that?

@ThierryA ThierryA merged commit f877050 into develop Jan 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/get_validated_css_file_path branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.