Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMP preview icon in Firefox #920

Conversation

Projects
None yet
2 participants
@zigasancin
Copy link
Contributor

zigasancin commented Jan 30, 2018

The AMP preview icon isn't displaying correctly in Firefox - see screenshot below (probably because of a different interpretation of the text-indent css rule). My proposed fix works in latest releases of Firefox, Chrome, Safari, Edge and IE.

fix-amp-wp-preview-icon-in-firefox

Fix AMP preview icon in Firefox
The AMP preview icon isn't displaying correctly in Firefox (probably because of a different interpretation of the text-indent css rule). My proposed fix works in latest releases of Firefox, Chrome, Safari, Edge and IE.

@westonruter westonruter added this to the v0.7 milestone Feb 1, 2018

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented Feb 1, 2018

Sure enough! Not sure how that was missed. With patch, it looks like the following in Chrome, Firefox, and Safari:

image

This could be cherry-picked into a 0.6.1 release if we do one.

@westonruter westonruter merged commit 72638ca into ampproject:develop Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@westonruter westonruter modified the milestones: v0.7, v0.6 Feb 11, 2018

@westonruter westonruter referenced this pull request Feb 11, 2018

Merged

VIP Review Changes #953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.