Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WP-CLI Script to create Comments #924

Merged
merged 7 commits into from Feb 1, 2018

Conversation

Projects
None yet
3 participants
@DavidCramer
Copy link
Contributor

DavidCramer commented Feb 1, 2018

Fixes #861

@DavidCramer DavidCramer requested a review from ThierryA Feb 1, 2018

DavidCramer and others added some commits Feb 1, 2018

@ThierryA

This comment has been minimized.

Copy link
Collaborator

ThierryA commented Feb 1, 2018

@DavidCramer I pushed two commits to reduce complexity a bit. I like your approach to get content using the Lorem API but it is maybe a bit over thinking, it shouldn’t be a blocker to run the script and a simple string with a bit of magic does the job.
Please take a look at my changes to double check them and this will be good to go.

@DavidCramer

This comment has been minimized.

Copy link
Contributor Author

DavidCramer commented Feb 1, 2018

@ThierryA I agree. I looked at the changes and its nice and simple. good work on that content generator. nice and simple. I may steal that..

@ThierryA ThierryA merged commit 5ac374f into develop Feb 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter added this to the v0.7 milestone Feb 3, 2018

@westonruter westonruter deleted the add/861-cli-script-for-comments branch Feb 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.