Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent New Relic script from being injected in AMP responses #932

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@westonruter
Copy link
Member

commented Feb 5, 2018

Note that to Monitor AMP pages with New Relic Browser you must apparently generate a license key, so there's nothing we can do to automate that. We'll need to add docs in the wiki for how to set that up. Perhaps we could add a UI for supplying the license ID later.

In the mean time, the important thing is to prevent New Relic from causing AMP pages to be invalid.

Fixes #808.

@westonruter westonruter added this to the v0.7 milestone Feb 5, 2018

@westonruter westonruter requested a review from ThierryA Feb 5, 2018

@westonruter westonruter merged commit 7b88ae0 into develop Feb 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the fix/newrelic branch Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.