New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run spec update to add support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro #943

Merged
merged 9 commits into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@adamsilverstein
Copy link
Contributor

adamsilverstein commented Feb 8, 2018

Includes updates to other elements and attributes in the validator spec.

Fixes #941

@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented Feb 8, 2018

@adamsilverstein does this successfully result in amp-mathml elements not being removed?

Could you add a test to test-tag-and-attribute-sanitizer.php to verify that a valid amp-mathml element survives validation and also that the sanitizer automatically picks up the amp-mathml component script?

For example:

https://github.com/Automattic/amp-wp/blob/c701b0b8614e4b454bf620950018d0f143796d3c/tests/test-tag-and-attribute-sanitizer.php#L156-L160

@adamsilverstein

This comment has been minimized.

Copy link
Contributor

adamsilverstein commented Feb 9, 2018

It should, I see the tags added to the generated file: https://github.com/Automattic/amp-wp/pull/943/files#diff-a761ebd1d4f764d95add0829d1378635R1325

I'll add some tests for this and other new amp-html tags I see added to the validation file.

@westonruter westonruter added this to the v0.7 milestone Feb 9, 2018

@adamsilverstein

This comment has been minimized.

Copy link
Contributor

adamsilverstein commented Feb 9, 2018

@westonruter I added tests for the new components I see in the pr that had matching docs at https://www.ampproject.org/docs/reference/components - namely amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content & amp-bind-macro. I tried amp-facebook-page, but I think it is too new and not in production (https://github.com/ampproject/amphtml/blob/9673d3fe860d5d61eb9b1193fc2a49b59cdf094c/extensions/amp-facebook-page/amp-facebook-page.md), the test failed so I removed it.

@westonruter westonruter changed the title update validators by running ./bin/amphtml-update.sh Run spec update with support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro Feb 9, 2018

@westonruter westonruter changed the title Run spec update with support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro Run spec update to add support for amp-mathml, amp-riddle-quiz, amp-wistia-player, amp-byside-content, amp-bind-macro Feb 9, 2018

@westonruter
Copy link
Member

westonruter left a comment

This is great. Thanks!

@westonruter westonruter merged commit 1ab37c6 into ampproject:develop Feb 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@westonruter

This comment has been minimized.

Copy link
Member

westonruter commented Feb 9, 2018

Behold: amp-mathml rendered in a WordPress post!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment