New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#933 Default stylesheet includes for theme support #964

Merged
merged 3 commits into from Feb 21, 2018

Conversation

Projects
None yet
2 participants
@kaitnyl
Copy link
Contributor

kaitnyl commented Feb 15, 2018

This addresses issue #933 where some styles in the legacy stylesheet are being referenced inside of sanitizers.

After taking a look through the sanitizers and style.php, it seems those two mentioned in #933 are the important ones.

The only other style referenced is for .amp-wp-iframe-placeholder as the iframe sanitizer adds this to the page when told to, but this one doesn't appear necessary.

Fixes #933.

@kaitnyl kaitnyl self-assigned this Feb 20, 2018

@kaitnyl kaitnyl changed the title [WIP] #933 Default stylesheet includes for theme support #933 Default stylesheet includes for theme support Feb 20, 2018

@kaitnyl kaitnyl requested review from westonruter and ThierryA Feb 20, 2018

@westonruter westonruter added this to the v0.7 milestone Feb 21, 2018

@westonruter westonruter merged commit d323697 into develop Feb 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@westonruter westonruter deleted the add/933-default-stylesheet branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment