Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate usage of who.yaml for ads vendors page #1318

Closed
matthiasrohmer opened this issue Dec 20, 2018 · 1 comment

Comments

@matthiasrohmer
Copy link
Collaborator

commented Dec 20, 2018

Objective

/content/includes/who.yaml which is used as a data source for pages/content/amp-dev/documentation/guides-and-tutorials/develop/monetization/ads_vendors.md is missing and breaks the build.

Background

ads_vendors.md tries to list supporting tech companies (should live in a key named tech_companies). I tried to migrate the who.yaml from master but it isn't there which is strange because the file is also still used on that branch and is therefore missing there as well.

Tasks

  • Find out what happend to who.yaml on master
  • Migrate potentially connected changes to future
@matthiasrohmer

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 20, 2018

I removed pages/content/amp-dev/documentation/guides-and-tutorials/develop/monetization/ads_vendors.md for now to unblock build.

matthiasrohmer added a commit that referenced this issue Dec 20, 2018

@matthiasrohmer matthiasrohmer self-assigned this Apr 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.