Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixi: Recommendations not always shown for image size, srcset, next gen formats #4955

Closed
kevinkimball opened this issue Nov 11, 2020 · 2 comments 路 Fixed by #4958
Closed

Pixi: Recommendations not always shown for image size, srcset, next gen formats #4955

kevinkimball opened this issue Nov 11, 2020 · 2 comments 路 Fixed by #4958

Comments

@kevinkimball
Copy link

kevinkimball commented Nov 11, 2020

馃悰 Bug Report

Current behavior

Recommendations is not always shown for image size, use srcset, and next gen formats even when the page could have savings with smaller images, doesn't use srcset, or doesn't use next gen formats.

I believe this is because PSI reports the page as "passing" even though the page is not adopting the recommendations.

Expected behavior/code

If the page could have smaller image sizes, expect to see a recommendation.
If the page is not using srcset, expect to see a recommendation to use srcset.
If the page is not using webp, expect a recommendation for webp.

Reproduction procedure

Visit the tool and put in a page url. For example here

Observe there are no recommendations re: srcset, webp, smaller image size.

Visit the PageSpeed Insights tool for the same URL and observe reservations (that are still marked green/passing).

  • What browser are you using? Chrome 87
  • What O/S are you using? OSX

cc @nainar @caroqliu

@kevinkimball
Copy link
Author

Is this resolved by #4666?

@matthiasrohmer
Copy link
Collaborator

Nope, #4666 was really just introducing the image recommendations including their details in the first place. It's exactly as you assumed 馃槈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants